mailbox: th1520: fix clock imbalance on probe failure

The purpose of the devm_add_action_or_reset() helper is to call the
action function in case adding an action ever fails so drop the clock
disable from the error path to avoid disabling the clocks twice.

Fixes: 5d4d263e1c6b ("mailbox: Introduce support for T-head TH1520 Mailbox driver")
Cc: Michal Wilczynski <m.wilczynski@samsung.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Michal Wilczynski <m.wilczynski@samsung.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>

diff --git a/drivers/mailbox/mailbox-th1520.c b/drivers/mailbox/mailbox-th1520.c
index a6b2aa9ae952067cf603e147006eeefbe5793968..626957c2e435cd912b41e9fc556876d2d45c2167 100644 (file)
--- a/drivers/mailbox/mailbox-th1520.c
+++ b/drivers/mailbox/mailbox-th1520.c
@@ -435,10 +435,8 @@ static int th1520_mbox_probe(struct platform_device *pdev)
        }
 
        ret = devm_add_action_or_reset(dev, th1520_disable_clk, priv);
-       if (ret) {
-               clk_bulk_disable_unprepare(ARRAY_SIZE(priv->clocks), priv->clocks);
+       if (ret)
                return ret;
-       }
 
        /*
         * The address mappings in the device tree align precisely with those