Replace incorrect use of snprintf in unit tests with tor_snprintf

This avoids a potential out of bounds write.

diff --git a/src/test/test_tortls.c b/src/test/test_tortls.c
index cbbd7dd3f346346e667196889a6a8c1eb5ae7318..98f5facc1199991e1cb012e123d780f7149e3fa0 100644 (file)
--- a/src/test/test_tortls.c
+++ b/src/test/test_tortls.c
@@ -1808,9 +1808,10 @@ test_tortls_debug_state_callback(void *ignored)
 
   tor_tls_debug_state_callback(ssl, 32, 45);
 
-  n = snprintf(buf, 1000, "SSL %p is now in state unknown"
+  n = tor_snprintf(buf, 1000, "SSL %p is now in state unknown"
                " state [type=32,val=45].\n", ssl);
-  buf[n]='\0';
+  /* tor's snprintf returns -1 on error */
+  tt_int_op(n, OP_NE, -1);
   expect_log_msg(buf);
 
  done: