]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: rme32.c irq enabling after spin_lock_irq
authorDenis Efremov <yefremov.denis@gmail.com>
Mon, 11 Feb 2013 15:04:06 +0000 (19:04 +0400)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 6 Mar 2013 03:23:55 +0000 (03:23 +0000)
commit f49a59c4471d81a233e09dda45187cc44fda009d upstream.

According to the other code in this driver and similar
code in rme96 it seems, that spin_lock_irq in
snd_rme32_capture_close function should be paired
with spin_unlock_irq.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Denis Efremov <yefremov.denis@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/pci/rme32.c

index 21bcb47fab50ef5d4de43708d7beb72105d4013d..62075a51cff387d6ac0011c5815d9e63b6d89026 100644 (file)
@@ -1017,7 +1017,7 @@ static int snd_rme32_capture_close(struct snd_pcm_substream *substream)
        spin_lock_irq(&rme32->lock);
        rme32->capture_substream = NULL;
        rme32->capture_periodsize = 0;
-       spin_unlock(&rme32->lock);
+       spin_unlock_irq(&rme32->lock);
        return 0;
 }