]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mctp: i2c: fix skb memory leak in receive path
authorHaiyue Wang <haiyuewa@163.com>
Thu, 5 Mar 2026 14:32:34 +0000 (22:32 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 10 Mar 2026 10:10:55 +0000 (11:10 +0100)
When 'midev->allow_rx' is false, the newly allocated skb isn't consumed
by netif_rx(), it needs to free the skb directly.

Fixes: f5b8abf9fc3d ("mctp i2c: MCTP I2C binding driver")
Signed-off-by: Haiyue Wang <haiyuewa@163.com>
Link: https://patch.msgid.link/20260305143240.97592-1-haiyuewa@163.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/mctp/mctp-i2c.c

index de6bc1736734a839a00238cd62f3766a2bb91b83..15fe4d1163c1cd665ccd01c1f1f429d931564a61 100644 (file)
@@ -343,6 +343,7 @@ static int mctp_i2c_recv(struct mctp_i2c_dev *midev)
        } else {
                status = NET_RX_DROP;
                spin_unlock_irqrestore(&midev->lock, flags);
+               kfree_skb(skb);
        }
 
        if (status == NET_RX_SUCCESS) {