pidl: Make sure to cast whole expressions

$cvar could be an expression such as ‘1 << 10’. In such cases this cast
presumably was intended to apply to the entire expression, not just to
the ‘1’.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index 0472f3b01c8ecfa6b7c3cf86eb2b7bdef894fc2f..57f8e8b5638f685423ae746fd8ac89611aa40926 100644 (file)
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -2082,11 +2082,11 @@ sub ConvertScalarToPython($$$$)
        # possibly 64 bit unsigned long.  (enums are signed in C,
        # unsigned in NDR)
        if ($ctypename =~ /^(uint32|uint3264)$/) {
-               return "PyLong_FromUnsignedLongLong((uint32_t)$cvar)";
+               return "PyLong_FromUnsignedLongLong((uint32_t)($cvar))";
        }
 
        if ($ctypename =~ /^(uint|uint8|uint16|uint1632)$/) {
-               return "PyLong_FromLong((uint16_t)$cvar)";
+               return "PyLong_FromLong((uint16_t)($cvar))";
        }
 
        if ($ctypename eq "DATA_BLOB") {