]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Fix an incorrect comment in iobase_is_closed (GH-102952)
authorJonathon Reinhart <JonathonReinhart@users.noreply.github.com>
Tue, 16 Jan 2024 16:27:17 +0000 (11:27 -0500)
committerGitHub <noreply@github.com>
Tue, 16 Jan 2024 16:27:17 +0000 (18:27 +0200)
This comment appears to have been mistakenly copied from what is now
called iobase_check_closed() in commit 4d9aec022063.

Also unite the iobase_check_closed() code with the relevant comment.

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Modules/_io/iobase.c

index 4da8e5bd572d745214ed080ccbe7d383716daeee..184e0b7d1aa7f1a12ca62e594cec1336fe0c79f9 100644 (file)
@@ -66,12 +66,19 @@ PyDoc_STRVAR(iobase_doc,
     "with open('spam.txt', 'r') as fp:\n"
     "    fp.write('Spam and eggs!')\n");
 
-/* Use this macro whenever you want to check the internal `closed` status
+
+/* Internal methods */
+
+/* Use this function whenever you want to check the internal `closed` status
    of the IOBase object rather than the virtual `closed` attribute as returned
    by whatever subclass. */
 
+static int
+iobase_is_closed(PyObject *self)
+{
+    return PyObject_HasAttrWithError(self, &_Py_ID(__IOBase_closed));
+}
 
-/* Internal methods */
 static PyObject *
 iobase_unsupported(_PyIO_State *state, const char *message)
 {
@@ -145,14 +152,6 @@ _io__IOBase_truncate_impl(PyObject *self, PyTypeObject *cls,
     return iobase_unsupported(state, "truncate");
 }
 
-static int
-iobase_is_closed(PyObject *self)
-{
-    /* This gets the derived attribute, which is *not* __IOBase_closed
-       in most cases! */
-    return PyObject_HasAttrWithError(self, &_Py_ID(__IOBase_closed));
-}
-
 /* Flush and close methods */
 
 /*[clinic input]