]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Note a slightly less likely way to violate ExcludeNodes
authorNick Mathewson <nickm@torproject.org>
Mon, 28 Mar 2011 20:51:00 +0000 (16:51 -0400)
committerNick Mathewson <nickm@torproject.org>
Wed, 27 Apr 2011 03:54:16 +0000 (23:54 -0400)
src/or/circuitlist.c

index d11b457944dcbf7e1379ff56ff39e7a900069bd3..42073fb96eacd2e86f13c4d8d27e767bd64208d4 100644 (file)
@@ -933,6 +933,11 @@ circuit_find_to_cannibalize(uint8_t purpose, extend_info_t *info,
             "capacity %d, internal %d",
             purpose, need_uptime, need_capacity, internal);
 
+  /* XXX022-1090 We should make sure that when we cannibalize a circuit, it
+   * contains no excluded nodes.  (This is possible if StrictNodes is 0, and
+   * we thought we needed to use an excluded exit node for, say, a directory
+   * operation.) -NM */
+
   for (_circ=global_circuitlist; _circ; _circ = _circ->next) {
     if (CIRCUIT_IS_ORIGIN(_circ) &&
         _circ->state == CIRCUIT_STATE_OPEN &&