]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: cs4265: sort the register default table
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Wed, 5 Aug 2026 08:24:13 +0000 (11:24 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 5 Aug 2026 12:34:36 +0000 (13:34 +0100)
reg_defaults must be sorted by ascending register address, as
regcache_lookup_reg() locates entries in it with bsearch().  See commit
fd80df352ba1 ("regcache: Add support for sorting defaults arrays").

cs4265_reg_defaults[] lists CS4265_INT_MASK (0x0e),
CS4265_STATUS_MODE_MSB (0x0f) and CS4265_STATUS_MODE_LSB (0x10) after
CS4265_SPDIF_CTL1 (0x11) and CS4265_SPDIF_CTL2 (0x12), so the binary search
does not find those three entries.  regcache_reg_needs_sync() then cannot
compare them against their default and reports that a sync is needed, so
they are written to the device on every regcache_sync() even when they were
never touched.

Sort the table by register address.

Fixes: fb6f806967f6 ("ASoC: Add support for the CS4265 CODEC")
Cc: stable@vger.kernel.org
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20260805082413.26174-4-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs4265.c

index 286d5ca2985411e59356aec249882bc25fc09b79..0b7d6826f4e91382ed3e4f63753d40512f9342ae 100644 (file)
@@ -46,11 +46,11 @@ static const struct reg_default cs4265_reg_defaults[] = {
        { CS4265_DAC_CHA_VOL, 0x00 },
        { CS4265_DAC_CHB_VOL, 0x00 },
        { CS4265_DAC_CTL2, 0xC0 },
-       { CS4265_SPDIF_CTL1, 0x00 },
-       { CS4265_SPDIF_CTL2, 0x00 },
        { CS4265_INT_MASK, 0x00 },
        { CS4265_STATUS_MODE_MSB, 0x00 },
        { CS4265_STATUS_MODE_LSB, 0x00 },
+       { CS4265_SPDIF_CTL1, 0x00 },
+       { CS4265_SPDIF_CTL2, 0x00 },
 };
 
 static bool cs4265_readable_register(struct device *dev, unsigned int reg)