]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iommu/omap: Use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Fri, 29 Aug 2025 14:02:19 +0000 (22:02 +0800)
committerJoerg Roedel <joerg.roedel@amd.com>
Fri, 5 Sep 2025 12:58:26 +0000 (14:58 +0200)
Change the 'ret' variable from u32 to int to store negative error codes
or zero;

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly. Additionally, assigning negative error codes to
unsigned type may trigger a GCC warning when the -Wsign-conversion flag
is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20250829140219.121783-1-rongqianfeng@vivo.com
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/omap-iommu.c

index 6fb93927bdb98a17f406768d12180e23ea01f3f2..5c6f5943f44b1ff8bf3ba697085e3b07004b9c81 100644 (file)
@@ -1303,8 +1303,8 @@ static int omap_iommu_map(struct iommu_domain *domain, unsigned long da,
        struct omap_iommu_device *iommu;
        struct omap_iommu *oiommu;
        struct iotlb_entry e;
+       int ret = -EINVAL;
        int omap_pgsz;
-       u32 ret = -EINVAL;
        int i;
 
        omap_pgsz = bytes_to_iopgsz(bytes);