]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: pse-pd: set user byte command SUB2 field
authorRobert Marko <robert.marko@sartura.hr>
Thu, 11 Jun 2026 10:24:49 +0000 (12:24 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 17 Jun 2026 22:57:16 +0000 (15:57 -0700)
The Set User Byte to Save command has three subject bytes.
The PD692x0 protocol guides defines SUB2 with value 0x4e, while SUB1
carries the NVM user byte.

Template only initialized SUB and SUB1.
Fill SUB2 explicitly so the command matches the documented layout.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Acked-by: Kory Maincent <kory.maincent@bootlin.com>
Link: https://patch.msgid.link/20260611102517.445549-1-robert.marko@sartura.hr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pse-pd/pd692x0.c

index cb377d5ba7afafa5e2313b7a7c9dcdcb79c6a7e7..209de9cec849aaa437d90939e8da1c5dc2a9d465 100644 (file)
@@ -200,7 +200,7 @@ static const struct pd692x0_msg pd692x0_msg_template_list[PD692X0_MSG_CNT] = {
        },
        [PD692X0_MSG_SET_USER_BYTE] = {
                .key = PD692X0_KEY_PRG,
-               .sub = {0x41, PD692X0_USER_BYTE},
+               .sub = {0x41, PD692X0_USER_BYTE, 0x4e},
                .data = {0x4e, 0x4e, 0x4e, 0x4e,
                         0x4e, 0x4e, 0x4e, 0x4e},
        },