Revert "workqueue: Factor out pwq_is_empty()"

This reverts commit 70abdc2f6c906ffea699f6e0e08fcbd9437e6bcc which is commit
afa87ce85379e2d93863fce595afdb5771a84004 upstream.

The workqueue patches backported to 6.8.y caused some reported
regressions, so revert them for now.

Reported-by: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Tejun Heo <tj@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Audra Mitchell <audra@redhat.com>
Link: https://lore.kernel.org/all/ce4c2f67-c298-48a0-87a3-f933d646c73b@leemhuis.info/
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 6d0f64b5918ba79c6270524de109e21777dc1546..8ee754dd319da9055e12a45fb521b542c36e24dd 100644 (file)
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1456,11 +1456,6 @@ static void put_pwq_unlocked(struct pool_workqueue *pwq)
        }
 }
 
-static bool pwq_is_empty(struct pool_workqueue *pwq)
-{
-       return !pwq->nr_active && list_empty(&pwq->inactive_works);
-}
-
 static void pwq_activate_inactive_work(struct work_struct *work)
 {
        struct pool_workqueue *pwq = get_work_pwq(work);
@@ -3330,7 +3325,7 @@ reflush:
                bool drained;
 
                raw_spin_lock_irq(&pwq->pool->lock);
-               drained = pwq_is_empty(pwq);
+               drained = !pwq->nr_active && list_empty(&pwq->inactive_works);
                raw_spin_unlock_irq(&pwq->pool->lock);
 
                if (drained)
@@ -4777,7 +4772,7 @@ static bool pwq_busy(struct pool_workqueue *pwq)
 
        if ((pwq != pwq->wq->dfl_pwq) && (pwq->refcnt > 1))
                return true;
-       if (!pwq_is_empty(pwq))
+       if (pwq->nr_active || !list_empty(&pwq->inactive_works))
                return true;
 
        return false;
@@ -5215,7 +5210,7 @@ void show_one_workqueue(struct workqueue_struct *wq)
        unsigned long flags;
 
        for_each_pwq(pwq, wq) {
-               if (!pwq_is_empty(pwq)) {
+               if (pwq->nr_active || !list_empty(&pwq->inactive_works)) {
                        idle = false;
                        break;
                }
@@ -5227,7 +5222,7 @@ void show_one_workqueue(struct workqueue_struct *wq)
 
        for_each_pwq(pwq, wq) {
                raw_spin_lock_irqsave(&pwq->pool->lock, flags);
-               if (!pwq_is_empty(pwq)) {
+               if (pwq->nr_active || !list_empty(&pwq->inactive_works)) {
                        /*
                         * Defer printing to avoid deadlocks in console
                         * drivers that queue work while holding locks