]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: spoolss: Make parameters in call to user_ok_token() match all other uses.
authorJeremy Allison <jra@samba.org>
Thu, 5 Nov 2020 23:48:08 +0000 (15:48 -0800)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 9 Nov 2020 04:10:45 +0000 (04:10 +0000)
We already have p->session_info->unix_info->unix_name, we don't
need to go through a legacy call to uidtoname(p->session_info->unix_token->uid).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14568

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Nov  9 04:10:45 UTC 2020 on sn-devel-184

source3/rpc_server/spoolss/srv_spoolss_nt.c

index f814ad96bf4ebf56dd5dd609161285bd54c05d7a..840e0280a7309902cd9dcfb66750d04fa5427bc7 100644 (file)
@@ -1880,7 +1880,8 @@ WERROR _spoolss_OpenPrinterEx(struct pipes_struct *p,
                        return WERR_ACCESS_DENIED;
                }
 
-               if (!user_ok_token(uidtoname(p->session_info->unix_token->uid), NULL,
+               if (!user_ok_token(p->session_info->unix_info->unix_name,
+                                  p->session_info->info->domain_name,
                                   p->session_info->security_token, snum) ||
                    !W_ERROR_IS_OK(print_access_check(p->session_info,
                                                      p->msg_ctx,