no need to have a separate assignment of the tcparray pointer followed

by a talloc_steal()
use the returned pointer in talloc_steal as the value to assign

(This used to be ctdb commit 5c6375ad3bbecfa725ec3b1477f259e5a8191866)

diff --git a/ctdb/server/ctdb_takeover.c b/ctdb/server/ctdb_takeover.c
index dcc16238f6736bc16bf78f5074dfb5e8b2dd51db..3ddd082c7e2cb9a0f3d1ef9f2d8f290a45439dee 100644 (file)
--- a/ctdb/server/ctdb_takeover.c
+++ b/ctdb/server/ctdb_takeover.c
@@ -154,8 +154,7 @@ static void takeover_ip_callback(struct ctdb_context *ctdb, int status,
        if (tcparray) {
                /* add all of the known tcp connections for this IP to the
                   list of tcp connections to send tickle acks for */
-               arp->tcparray = tcparray;
-               talloc_steal(arp, tcparray);
+               arp->tcparray = talloc_steal(arp, tcparray);
 
                state->node->tcp_array = NULL;
                state->node->tcp_update_needed = true;