]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
firmware: psci: Fix refcount leak in psci_dt_init
authorMiaoqian Lin <linmq006@gmail.com>
Tue, 18 Mar 2025 15:17:12 +0000 (23:17 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:04:02 +0000 (11:04 +0100)
[ Upstream commit 7ff37d29fd5c27617b9767e1b8946d115cf93a1e ]

Fix a reference counter leak in psci_dt_init() where of_node_put(np) was
missing after of_find_matching_node_and_match() when np is unavailable.

Fixes: d09a0011ec0d ("drivers: psci: Allow PSCI node to be disabled")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Gavin Shan <gshan@redhat.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20250318151712.28763-1-linmq006@gmail.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/firmware/psci/psci.c

index 00af99b6f97c1516347f61de8eab3311794602f3..2c435a8d3548723fbca2c3b2dad9e880afa547b0 100644 (file)
@@ -571,8 +571,10 @@ int __init psci_dt_init(void)
 
        np = of_find_matching_node_and_match(NULL, psci_of_match, &matched_np);
 
-       if (!np || !of_device_is_available(np))
+       if (!np || !of_device_is_available(np)) {
+               of_node_put(np);
                return -ENODEV;
+       }
 
        init_fn = (psci_initcall_t)matched_np->data;
        ret = init_fn(np);