oops. accidentally reintroduced a memory leak. put the bugfix back.

diff --git a/Modules/_sre.c b/Modules/_sre.c
index f5698f14778cd5c93ffdf9f96c4e0112fa007534..61ee694ad42b62abbf131d0f80f8a9a64fdd71c1 100644 (file)
--- a/Modules/_sre.c
+++ b/Modules/_sre.c
@@ -1704,10 +1704,11 @@ pattern_findall(PatternObject* self, PyObject* args)
                 break;
             }
 
-            if (PyList_Append(list, item) < 0) {
-                Py_DECREF(item);
+            status = PyList_Append(list, item);
+            Py_DECREF(item);
+
+            if (status < 0)
                 goto error;
-            }
 
             if (state.ptr == state.start)
                 state.start = (void*) ((char*) state.ptr + state.charsize);