]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
timekeeping: Fix bogus clock_was_set() invocation in do_adjtimex()
authorThomas Gleixner <tglx@linutronix.de>
Sat, 3 Aug 2024 15:07:51 +0000 (17:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:30 +0000 (15:34 +0200)
commit 5916be8a53de6401871bdd953f6c60237b47d6d3 upstream.

The addition of the bases argument to clock_was_set() fixed up all call
sites correctly except for do_adjtimex(). This uses CLOCK_REALTIME
instead of CLOCK_SET_WALL as argument. CLOCK_REALTIME is 0.

As a result the effect of that clock_was_set() notification is incomplete
and might result in timers expiring late because the hrtimer code does
not re-evaluate the affected clock bases.

Use CLOCK_SET_WALL instead of CLOCK_REALTIME to tell the hrtimers code
which clock bases need to be re-evaluated.

Fixes: 17a1b8826b45 ("hrtimer: Add bases argument to clock_was_set()")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/877ccx7igo.ffs@tglx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/time/timekeeping.c

index 4e18db1819f842a6e9d2ce4837519e688b67ca06..0381366c541e0dcd4b8db318eae463d1a126d7d8 100644 (file)
@@ -2479,7 +2479,7 @@ int do_adjtimex(struct __kernel_timex *txc)
                clock_set |= timekeeping_advance(TK_ADV_FREQ);
 
        if (clock_set)
-               clock_was_set(CLOCK_REALTIME);
+               clock_was_set(CLOCK_SET_WALL);
 
        ntp_notify_cmos_timer();