]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
accel/qaic: Replace snprintf() with sysfs_emit() in sysfs show functions
authorChelsy Ratnawat <chelsyratnawat2001@gmail.com>
Fri, 22 Aug 2025 11:28:04 +0000 (04:28 -0700)
committerJeff Hugo <jeff.hugo@oss.qualcomm.com>
Mon, 6 Oct 2025 20:38:20 +0000 (14:38 -0600)
Documentation/filesystems/sysfs.rst mentions that show() should only
use sysfs_emit() or sysfs_emit_at() when formatting the value to be
returned to user space. So replace snprintf() with sysfs_emit().

Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
[jhugo: Fix commit text typos]
Signed-off-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250822112804.1726592-1-chelsyratnawat2001@gmail.com
drivers/accel/qaic/qaic_ras.c

index 914ffc4a9970dea20ea9d0f43e2ef1f444b20839..f1d52a710136a768ed08b415db394bb9945262bc 100644 (file)
@@ -514,21 +514,21 @@ static ssize_t ce_count_show(struct device *dev, struct device_attribute *attr,
 {
        struct qaic_device *qdev = pci_get_drvdata(to_pci_dev(dev));
 
-       return snprintf(buf, PAGE_SIZE, "%d\n", qdev->ce_count);
+       return sysfs_emit(buf, "%d\n", qdev->ce_count);
 }
 
 static ssize_t ue_count_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
        struct qaic_device *qdev = pci_get_drvdata(to_pci_dev(dev));
 
-       return snprintf(buf, PAGE_SIZE, "%d\n", qdev->ue_count);
+       return sysfs_emit(buf, "%d\n", qdev->ue_count);
 }
 
 static ssize_t ue_nonfatal_count_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
        struct qaic_device *qdev = pci_get_drvdata(to_pci_dev(dev));
 
-       return snprintf(buf, PAGE_SIZE, "%d\n", qdev->ue_nf_count);
+       return sysfs_emit(buf, "%d\n", qdev->ue_nf_count);
 }
 
 static DEVICE_ATTR_RO(ce_count);