]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
target/arm/tcg: Drop unnecessary aa64_sve check from do_trans_pmull()
authorPeter Maydell <peter.maydell@linaro.org>
Wed, 18 Feb 2026 18:40:14 +0000 (18:40 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Wed, 18 Feb 2026 18:40:14 +0000 (18:40 +0000)
Part of the logic inside do_trans_pmull() applies the aa64_sve
feature check for the non-128-bit-element versions of these insns
(PMULLB and PMULLT).  This is currently a redundant check because we
only invoke this function via the macro invocation
 TRANS_FEAT(..., aa64_sve2, do_trans_pmull, ...)
and it's actively wrong for an SME-only CPU, because these insns
are also available via SME. Remove the unnecessary logic.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20260202133353.2231685-10-peter.maydell@linaro.org

target/arm/tcg/translate-sve.c

index e853b4dd0a364c24bf413f139bb9514a39e20bb9..fe59126d2b46fa962481a5711b782d24c290be5f 100644 (file)
@@ -6782,8 +6782,6 @@ static bool do_trans_pmull(DisasContext *s, arg_rrr_esz *a, bool sel)
             return false;
         }
         s->is_nonstreaming = true;
-    } else if (!dc_isar_feature(aa64_sve, s)) {
-        return false;
     }
     return gen_gvec_ool_arg_zzz(s, fns[a->esz], a, sel);
 }