Revert os.py 1.75, and directly implement update.

Fixes #1110478 and #1100235.

diff --git a/Lib/os.py b/Lib/os.py
index 65b1830f8b9afc1eaab8b5903decc687fbcdf8fc..b34e413553e7a4608159a0f60ec0a899bdd19ff0 100644 (file)
--- a/Lib/os.py
+++ b/Lib/os.py
@@ -435,6 +435,17 @@ else:
                 return key.upper() in self.data
             def get(self, key, failobj=None):
                 return self.data.get(key.upper(), failobj)
+            def update(self, dict=None, **kwargs):
+                if dict:
+                    try:
+                        items = dict.items()
+                    except AttributeError:
+                        # List of (key, value)
+                        items = dict
+                    for k, v in items:
+                        self[k] = v
+                if kwargs:
+                    self.update(kwargs)
             def copy(self):
                 return dict(self)
 
@@ -446,6 +457,17 @@ else:
             def __setitem__(self, key, item):
                 putenv(key, item)
                 self.data[key] = item
+            def update(self,  dict=None, **kwargs):
+                if dict:
+                    try:
+                        items = dict.items()
+                    except AttributeError:
+                        # List of (key, value)
+                        items = dict
+                    for k, v in items:
+                        self[k] = v
+                if kwargs:
+                    self.update(kwargs)
             try:
                 unsetenv
             except NameError:

diff --git a/Misc/NEWS b/Misc/NEWS
index 08d90573243902431bf3c41b1ee80ee362b47331..33fd6366d40a958f955fec8fde71857e55900778 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -25,6 +25,8 @@ Core and builtins
 Library
 -------
 
+- Bug #1110478: Revert os.environ.update to do putenv again.
+
 - Bug #1103844: fix distutils.install.dump_dirs() with negated options.
 
 - Bug #1067732: wininst --install-script doesn't leave residual files anymore.