]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: dwc3: meson-g12a: fix device leaks at unbind
authorJohan Hovold <johan@kernel.org>
Thu, 24 Jul 2025 09:19:07 +0000 (11:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:22:49 +0000 (16:22 +0200)
commit 93b400f4951404d040197943a25d6fef9f8ccabb upstream.

Make sure to drop the references taken to the child devices by
of_find_device_by_node() during probe on driver unbind.

Fixes: c99993376f72 ("usb: dwc3: Add Amlogic G12A DWC3 glue")
Cc: stable@vger.kernel.org # 5.2
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://lore.kernel.org/r/20250724091910.21092-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-meson-g12a.c

index 2d3ca6e8eb654e7b7ea9f299555b18f106f9cc1a..a970eae93a205b55bd208b819a23f345be91239d 100644 (file)
@@ -844,6 +844,9 @@ static int dwc3_meson_g12a_remove(struct platform_device *pdev)
        if (priv->drvdata->otg_switch_supported)
                usb_role_switch_unregister(priv->role_switch);
 
+       put_device(priv->switch_desc.udc);
+       put_device(priv->switch_desc.usb2_port);
+
        of_platform_depopulate(dev);
 
        for (i = 0 ; i < PHY_COUNT ; ++i) {