usb: aspeed-vhub: Fix refcount leak bug in ast_vhub_init_desc()

[ Upstream commit 220fafb4ed04187e9c17be4152da5a7f2ffbdd8c ]

We should call of_node_put() for the reference returned by
of_get_child_by_name() which has increased the refcount.

Fixes: 30d2617fd7ed ("usb: gadget: aspeed: allow to set usb strings in device tree")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220713120528.368168-1-windhl@126.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
index bfd8e77788e29fe1c051b4f3f8ef14c772cb5dae..3a4ccc722db53b1254f8ab71e32b49d71422cbc0 100644 (file)
--- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c
@@ -1033,8 +1033,10 @@ static int ast_vhub_init_desc(struct ast_vhub *vhub)
        /* Initialize vhub String Descriptors. */
        INIT_LIST_HEAD(&vhub->vhub_str_desc);
        desc_np = of_get_child_by_name(vhub_np, "vhub-strings");
-       if (desc_np)
+       if (desc_np) {
                ret = ast_vhub_of_parse_str_desc(vhub, desc_np);
+               of_node_put(desc_np);
+       }
        else
                ret = ast_vhub_str_alloc_add(vhub, &ast_vhub_strings);