]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: sched: cls_api: fix tc_chain_fill_node to initialize tcm_info to zero to prevent...
authorYochai Eisenrich <echelonh@gmail.com>
Sat, 28 Mar 2026 21:14:36 +0000 (00:14 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 31 Mar 2026 00:56:40 +0000 (17:56 -0700)
When building netlink messages, tc_chain_fill_node() never initializes
the tcm_info field of struct tcmsg. Since the allocation is not zeroed,
kernel heap memory is leaked to userspace through this 4-byte field.

The fix simply zeroes tcm_info alongside the other fields that are
already initialized.

Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
Signed-off-by: Yochai Eisenrich <echelonh@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://patch.msgid.link/20260328211436.1010152-1-echelonh@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/cls_api.c

index 4829c27446e3369ad2ae9b3fcb285eca47d59933..20f7f9ee0b353a7296c24a772f47dae902defef2 100644 (file)
@@ -2969,6 +2969,7 @@ static int tc_chain_fill_node(const struct tcf_proto_ops *tmplt_ops,
        tcm->tcm__pad1 = 0;
        tcm->tcm__pad2 = 0;
        tcm->tcm_handle = 0;
+       tcm->tcm_info = 0;
        if (block->q) {
                tcm->tcm_ifindex = qdisc_dev(block->q)->ifindex;
                tcm->tcm_parent = block->q->handle;