]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-106751: Optimize SelectSelector.select() for many iteration case (gh-106879)
authorDong-hee Na <donghee.na@python.org>
Wed, 19 Jul 2023 06:12:38 +0000 (15:12 +0900)
committerGitHub <noreply@github.com>
Wed, 19 Jul 2023 06:12:38 +0000 (15:12 +0900)
Lib/selectors.py
Misc/NEWS.d/next/Library/2023-07-19-10-45-24.gh-issue-106751.3HJ1of.rst [new file with mode: 0644]

index d13405963f219de903b6d96e638b65b1ed3396cf..13497a24097232c65b5cf995fa293b84a44dd4a4 100644 (file)
@@ -314,17 +314,15 @@ class SelectSelector(_BaseSelectorImpl):
             r, w, _ = self._select(self._readers, self._writers, [], timeout)
         except InterruptedError:
             return ready
-        r = set(r)
-        w = set(w)
-        for fd in r | w:
-            events = 0
-            if fd in r:
-                events |= EVENT_READ
-            if fd in w:
-                events |= EVENT_WRITE
-
-            key = self._fd_to_key.get(fd)
+        r = frozenset(r)
+        w = frozenset(w)
+        rw = r | w
+        fd_to_key_get = self._fd_to_key.get
+        for fd in rw:
+            key = fd_to_key_get(fd)
             if key:
+                events = ((fd in r and EVENT_READ)
+                          | (fd in w and EVENT_WRITE))
                 ready.append((key, events & key.events))
         return ready
 
diff --git a/Misc/NEWS.d/next/Library/2023-07-19-10-45-24.gh-issue-106751.3HJ1of.rst b/Misc/NEWS.d/next/Library/2023-07-19-10-45-24.gh-issue-106751.3HJ1of.rst
new file mode 100644 (file)
index 0000000..2696b56
--- /dev/null
@@ -0,0 +1,2 @@
+Optimize :meth:`SelectSelector.select` for many iteration case. Patch By
+Dong-hee Na.