]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tty: vt: fix 20 vs 0x20 typo in EScsiignore
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Mon, 22 Jan 2024 11:03:17 +0000 (12:03 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:17:28 +0000 (18:17 -0400)
[ Upstream commit 0e6a92f67c8a94707f7bb27ac29e2bdf3e7c167d ]

The if (c >= 20 && c <= 0x3f) test added in commit 7a99565f8732 is
wrong.  20 is DC4 in ascii and it makes no sense to consider that as the
bottom limit. Instead, it should be 0x20 as in the other test in
the commit above. This is supposed to NOT change anything as we handle
interesting 20-0x20 asciis far before this if.

So for sakeness, change to 0x20 (which is SPACE).

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Fixes: 7a99565f8732 ("vt: ignore csi sequences with intermediate characters.")
Cc: Martin Hostettler <textshell@uchuujin.de>
Link: https://lore.kernel.org/all/ZaP45QY2WEsDqoxg@neutronstar.dyndns.org/
Tested-by: Helge Deller <deller@gmx.de> # parisc STI console
Link: https://lore.kernel.org/r/20240122110401.7289-4-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/vt/vt.c

index 38a765eadbe2bc81494f1fbd7a63b50b87101f08..52e6ca1ba21dfcdf0f421e415e0a10b109f9cb1b 100644 (file)
@@ -2469,7 +2469,7 @@ static void do_con_trol(struct tty_struct *tty, struct vc_data *vc, int c)
                }
                return;
        case EScsiignore:
-               if (c >= 20 && c <= 0x3f)
+               if (c >= 0x20 && c <= 0x3f)
                        return;
                vc->vc_state = ESnormal;
                return;