Mention proper fix for zsh users.

* lib/m4sugar/m4sh.m4 (_AS_DETECT_BETTER_SHELL): Recommend zsh
version known to work.
Suggested by Paolo Bonzini.

Signed-off-by: Eric Blake <ebb9@byu.net>

diff --git a/ChangeLog b/ChangeLog
index c59bb9472a0c703a196c039ad4a65ac1fae54fdc..682b9195801f7fe9d8ea316dc1251b64411e9143 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2008-10-29  Eric Blake  <ebb9@byu.net>
 
+       Mention known zsh bug.
+       * lib/m4sugar/m4sh.m4 (_AS_DETECT_BETTER_SHELL): Recommend zsh
+       version known to work.
+       Suggested by Paolo Bonzini.
+
        Document current beta-quality status.
        * configure.ac: Reflect fact that change to git-version-gen
        produces -, but not always a letter, on non-release builds.

diff --git a/lib/m4sugar/m4sh.m4 b/lib/m4sugar/m4sh.m4
index a9b6aec0f62d092d196263b33dedb630ca0189de..341a2896fd1e41c718567be949751408c3ca9d5e 100644 (file)
--- a/lib/m4sugar/m4sh.m4
+++ b/lib/m4sugar/m4sh.m4
@@ -238,14 +238,19 @@ dnl Remove any tests from suggested that are also required
 
 dnl Unfortunately, $as_me isn't available here.
     AS_IF([test x$as_have_required = xno],
-      [AS_ECHO("m4_text_wrap([This script requires a shell more modern than
-all the shells that I found on your system.  Please tell]
-m4_defn([m4_PACKAGE_BUGREPORT])
-m4_ifset([AC_PACKAGE_BUGREPORT], [m4_if(m4_defn([m4_PACKAGE_BUGREPORT]),
-m4_defn([AC_PACKAGE_BUGREPORT]), [], [ and m4_defn([AC_PACKAGE_BUGREPORT])])])
+      [AS_ECHO(["$[]0: This script requires a shell more modern than all"])
+  AS_ECHO(["$[]0: the shells that I found on your system."])
+  if test x${ZSH_VERSION+set} = xset ; then
+    AS_ECHO(["$[]0: In particular, zsh $ZSH_VERSION has bugs and should"])
+    AS_ECHO(["$[]0: be upgraded to zsh 4.3.4 or later."])
+  else
+    AS_ECHO("m4_text_wrap([Please tell ]_m4_defn([m4_PACKAGE_BUGREPORT])
+m4_ifset([AC_PACKAGE_BUGREPORT], [m4_if(_m4_defn([m4_PACKAGE_BUGREPORT]),
+_m4_defn([AC_PACKAGE_BUGREPORT]), [], [and _m4_defn([AC_PACKAGE_BUGREPORT])])])
 [about your system, including any error possibly output before this message.
 Then install a modern shell, or manually run the script under such a
 shell if you do have one.], [$[]0: ], [], [62])")
+  fi
       AS_EXIT(1)])])
 fi
 _m4_popdef([AS_EXIT])])# _AS_DETECT_BETTER_SHELL