]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.12] gh-131677: Fix flaky test_lru_cache_threaded3 (gh-131679) (gh-131693)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 24 Mar 2025 20:59:03 +0000 (21:59 +0100)
committerGitHub <noreply@github.com>
Mon, 24 Mar 2025 20:59:03 +0000 (20:59 +0000)
The call to `with self.subTest(...)` was not thread-safe.
(cherry picked from commit a1232459860235f4fb7896cc95966d87a51cbe32)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Lib/test/test_functools.py

index 873170116f43cf800aec59637fa3a8a6f28bb6a0..cd7b8aac42c5e1204bce629f087c17983003ec8a 100644 (file)
@@ -1756,8 +1756,7 @@ class TestLRU:
             time.sleep(.01)
             return 3 * x
         def test(i, x):
-            with self.subTest(thread=i):
-                self.assertEqual(f(x), 3 * x, i)
+            self.assertEqual(f(x), 3 * x, i)
         threads = [threading.Thread(target=test, args=(i, v))
                    for i, v in enumerate([1, 2, 2, 3, 2])]
         with threading_helper.start_threads(threads):