]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
linux-user: Fix loaddr computation for some elf files
authorRichard Henderson <richard.henderson@linaro.org>
Tue, 14 Nov 2023 20:13:29 +0000 (12:13 -0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 29 Nov 2023 13:20:11 +0000 (16:20 +0300)
The file offset of the load segment is not relevant to the
low address, only the beginning of the virtual address page.

Cc: qemu-stable@nongnu.org
Fixes: a93934fecd4 ("elf: take phdr offset into account when calculating the program load address")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1952
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
(cherry picked from commit 82d70a84c8ee42ef969a9cfddc0f5b30b16165f5)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
linux-user/elfload.c

index c2c095d3839c6b861e7c4579f5ccc8318b7d5082..87895847ecefe895662950d71671ff6b2c4c020b 100644 (file)
@@ -3001,7 +3001,7 @@ static void load_elf_image(const char *image_name, int image_fd,
     for (i = 0; i < ehdr->e_phnum; ++i) {
         struct elf_phdr *eppnt = phdr + i;
         if (eppnt->p_type == PT_LOAD) {
-            abi_ulong a = eppnt->p_vaddr - eppnt->p_offset;
+            abi_ulong a = eppnt->p_vaddr & TARGET_PAGE_MASK;
             if (a < loaddr) {
                 loaddr = a;
             }