2007-06-14 Havoc Pennington <hp@redhat.com>

	* dbus/dbus-sysdeps-unix.c (_dbus_credentials_parse_and_add_user):
	delete this function since it was effectively the same as
	_dbus_credentials_add_from_username()

diff --git a/ChangeLog b/ChangeLog
index 4d4fc7bbe1950ae68e5ec85ab262489b388766fd..e5b9940efb8683d722ef4f0529bc26e4cb125941 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2007-06-14  Havoc Pennington  <hp@redhat.com>
+
+       * dbus/dbus-sysdeps-unix.c (_dbus_credentials_parse_and_add_user):
+       delete this function since it was effectively the same as
+       _dbus_credentials_add_from_username()
+
 2007-06-14  Havoc Pennington  <hp@redhat.com>
 
        * dbus/dbus-auth.c: adapt to keyring changes

diff --git a/dbus/dbus-auth.c b/dbus/dbus-auth.c
index 5164f17a7a7fc37fb0ff2f4fdfc29ea4d629205b..b23b1479370d451e29f0a3c1128e6b6d1953bc72 100644 (file)
--- a/dbus/dbus-auth.c
+++ b/dbus/dbus-auth.c
@@ -534,7 +534,7 @@ sha1_handle_first_client_response (DBusAuth         *auth,
         }
     }
       
-  if (!_dbus_credentials_add_from_username (auth->desired_identity, data))
+  if (!_dbus_credentials_add_from_user (auth->desired_identity, data))
     {
       _dbus_verbose ("%s: Did not get a valid username from client\n",
                      DBUS_AUTH_NAME (auth));
@@ -1062,8 +1062,8 @@ handle_server_data_external_mech (DBusAuth         *auth,
     }
   else
     {
-      if (!_dbus_credentials_parse_and_add_user(auth->desired_identity,
-                                                   &auth->identity))
+      if (!_dbus_credentials_add_from_user (auth->desired_identity,
+                                            &auth->identity))
         {
           _dbus_verbose ("%s: could not get credentials from uid string\n",
                          DBUS_AUTH_NAME (auth));

diff --git a/dbus/dbus-sysdeps-unix.c b/dbus/dbus-sysdeps-unix.c
index 725c4de7e878db9fe1842a981818dbaf57d6ea17..6ba3da0daa1e9276deed0cb86e8c9ae7fd8f780a 100644 (file)
--- a/dbus/dbus-sysdeps-unix.c
+++ b/dbus/dbus-sysdeps-unix.c
@@ -1505,33 +1505,6 @@ _dbus_credentials_add_from_current_process (DBusCredentials *credentials)
   return TRUE;
 }
 
-/**
- * Parses a desired identity provided from a client in the auth protocol.
- * On UNIX this means parsing a UID, on Windows probably parsing an
- * SID string.
- *
- * @todo this is broken because it treats OOM and parse error
- * the same way. Needs a #DBusError.
- * 
- * @param credentials the credentials to add what we parse to
- * @param desired_identity the string to parse
- * @returns #TRUE if we successfully parsed something
- */
-dbus_bool_t
-_dbus_credentials_parse_and_add_user (DBusCredentials  *credentials,
-                                         const DBusString *desired_identity)
-{
-  dbus_uid_t uid;
-
-  if (!_dbus_parse_uid (desired_identity, &uid))
-    return FALSE;
-
-  if (!_dbus_credentials_add_unix_uid (credentials, uid))
-    return FALSE;
-
-  return TRUE;
-}
-
 /**
  * Append to the string the identity we would like to have when we
  * authenticate, on UNIX this is the current process UID and on

diff --git a/dbus/dbus-sysdeps.h b/dbus/dbus-sysdeps.h
index aebf50c6f9ba9c65cb1f941c33097e4f0be90bb7..3e2b8cebb01db2ba4a1e304f92469853d7ed2e75 100644 (file)
--- a/dbus/dbus-sysdeps.h
+++ b/dbus/dbus-sysdeps.h
@@ -162,11 +162,9 @@ dbus_bool_t _dbus_read_credentials_socket (int               client_fd,
 dbus_bool_t _dbus_send_credentials_socket (int              server_fd,
                                            DBusError       *error);
 
-dbus_bool_t _dbus_credentials_add_from_username        (DBusCredentials  *credentials,
+dbus_bool_t _dbus_credentials_add_from_user            (DBusCredentials  *credentials,
                                                         const DBusString *username);
 dbus_bool_t _dbus_credentials_add_from_current_process (DBusCredentials  *credentials);
-dbus_bool_t _dbus_credentials_parse_and_add_user       (DBusCredentials  *credentials,
-                                                        const DBusString *desired_identity);
 dbus_bool_t _dbus_append_user_from_current_process     (DBusString        *str);
 
 dbus_bool_t _dbus_parse_unix_user_from_config   (const DBusString  *username,

diff --git a/dbus/dbus-userdb.c b/dbus/dbus-userdb.c
index 75475999fd7905061240ad2d96ac98d311f258e1..14c9c9e52974173817e359b754cc598832589229 100644 (file)
--- a/dbus/dbus-userdb.c
+++ b/dbus/dbus-userdb.c
@@ -477,13 +477,20 @@ _dbus_homedir_from_uid (dbus_uid_t         uid,
 /**
  * Adds the credentials corresponding to the given username.
  *
+ * Used among other purposes to parses a desired identity provided
+ * from a client in the auth protocol. On UNIX this means parsing a
+ * UID, on Windows probably parsing an SID string.
+ * 
+ * @todo this is broken because it treats OOM and parse error
+ * the same way. Needs a #DBusError.
+ * 
  * @param credentials credentials to fill in 
  * @param username the username
  * @returns #TRUE if the username existed and we got some credentials
  */
 dbus_bool_t
-_dbus_credentials_add_from_username (DBusCredentials  *credentials,
-                                     const DBusString *username)
+_dbus_credentials_add_from_user (DBusCredentials  *credentials,
+                                 const DBusString *username)
 {
   DBusUserDatabase *db;
   const DBusUserInfo *info;