Add clang's -Wstring-conversion, and fix the one place it hits

diff --git a/configure.ac b/configure.ac
index 85ba939a87bdcf931d021fb4859d6e7088c3f7eb..79457372f7194c39380c87d604ef2af422600fb6 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -1851,6 +1851,7 @@ if test "x$enable_gcc_warnings_advisory" != "xno"; then
      -Wstatic-local-in-inline
      -Wstrict-overflow=2
      -Wstring-compare
+     -Wstring-conversion
      -Wstrlcpy-strlcat-size
      -Wstrncat-size
      -Wsuggest-attribute=format

diff --git a/src/test/test_relaycell.c b/src/test/test_relaycell.c
index 1cd9ff064b4377b2ced1091749e6d30f46a96e2d..fb6748965aa38c19f696dfdbd40857ee45f7d8ad 100644 (file)
--- a/src/test/test_relaycell.c
+++ b/src/test/test_relaycell.c
@@ -95,7 +95,7 @@ test_relaycell_resolved(void *arg)
     tt_int_op(srm_ncalls, OP_EQ, 1);                                 \
     tt_ptr_op(srm_conn, OP_EQ, entryconn);                           \
     tt_int_op(srm_atype, OP_EQ, (atype));                            \
-    if (answer) {                                                 \
+    if ((answer) != NULL) {                                          \
       tt_int_op(srm_alen, OP_EQ, sizeof(answer)-1);                  \
       tt_int_op(srm_alen, OP_LT, 512);                                \
       tt_int_op(srm_answer_is_set, OP_EQ, 1);                        \