]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
execute: add FIXME comment
authorLennart Poettering <lennart@poettering.net>
Fri, 19 Jul 2024 12:40:47 +0000 (14:40 +0200)
committerLennart Poettering <lennart@poettering.net>
Fri, 19 Jul 2024 16:59:01 +0000 (18:59 +0200)
As requested by @YHNdnzj:

https://github.com/systemd/systemd/pull/33707#discussion_r1684055699

src/core/exec-invoke.c

index ea85c36581aa6b6bcaa364c2de7b5b63d287de53..8c7e29f17a449fddfdb9c5001fdea9d2ae97307d 100644 (file)
@@ -497,6 +497,9 @@ static int setup_output(
         i = fixup_input(context, socket_fd, params->flags & EXEC_APPLY_TTY_STDIN);
         o = fixup_output(context->std_output, socket_fd);
 
+        // FIXME: we probably should spend some time here to verify that if we inherit an fd from stdin
+        // (possibly indirect via inheritance from stdout) it is actually opened for write!
+
         if (fileno == STDERR_FILENO) {
                 ExecOutput e;
                 e = fixup_output(context->std_error, socket_fd);