ndrdump: avoid use after free

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Sun Nov 17 23:54:11 UTC 2019 on sn-devel-184

diff --git a/librpc/tools/ndrdump.c b/librpc/tools/ndrdump.c
index 2db6be3366bb8785bc168a1fccd5763256f9b221..e911cf4c1e416931796c282b181a03195b6a05cc 100644 (file)
--- a/librpc/tools/ndrdump.c
+++ b/librpc/tools/ndrdump.c
@@ -228,10 +228,11 @@ static NTSTATUS ndrdump_pull_and_print_pipes(const char *function,
                                return ndr_map_error2ntstatus(ndr_err);
                        }
                        pipes->pipes[i].ndr_print(ndr_print, n, c);
-                       talloc_free(c);
                        if (*count == 0) {
+                               talloc_free(c);
                                break;
                        }
+                       talloc_free(c);
                        idx++;
                }
        }