]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: most: dim2: replace BUG_ON() in poison_channel()
authorGabriel Rondon <grondon@gmail.com>
Mon, 30 Mar 2026 18:22:55 +0000 (19:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Mar 2026 08:46:39 +0000 (10:46 +0200)
Replace BUG_ON() range check on ch_idx with a return of -EINVAL.

BUG_ON() is deprecated as it crashes the entire kernel on assertion
failure (see Documentation/process/deprecated.rst).

Signed-off-by: Gabriel Rondon <grondon@gmail.com>
Link: https://patch.msgid.link/20260330182255.75241-6-grondon@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/most/dim2/dim2.c

index 23230a32c2cbd1d3b7a1c2104ad9176483d8776b..7953d4626752fbcce0c50b9bdf82f7bfabb70110 100644 (file)
@@ -647,7 +647,8 @@ static int poison_channel(struct most_interface *most_iface, int ch_idx)
        u8 hal_ret;
        int ret = 0;
 
-       BUG_ON(ch_idx < 0 || ch_idx >= DMA_CHANNELS);
+       if (ch_idx < 0 || ch_idx >= DMA_CHANNELS)
+               return -EINVAL;
 
        if (!hdm_ch->is_initialized)
                return -EPERM;