]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: amlogic: gxbb: drop incorrect flag on 32k clock
authorJerome Brunet <jbrunet@baylibre.com>
Fri, 20 Dec 2024 10:25:36 +0000 (11:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:30:57 +0000 (14:30 +0200)
[ Upstream commit f38f7fe4830c5cb4eac138249225f119e7939965 ]

gxbb_32k_clk_div sets CLK_DIVIDER_ROUND_CLOSEST in the init_data flag which
is incorrect. This is field is not where the divider flags belong.

Thankfully, CLK_DIVIDER_ROUND_CLOSEST maps to bit 4 which is an unused
clock flag, so there is no unintended consequence to this error.

Effectively, the clock has been used without CLK_DIVIDER_ROUND_CLOSEST
so far, so just drop it.

Fixes: 14c735c8e308 ("clk: meson-gxbb: Add EE 32K Clock for CEC")
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20241220-amlogic-clk-gxbb-32k-fixes-v1-1-baca56ecf2db@baylibre.com
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/meson/gxbb.c

index d42551a46ec913c73c4d049050e9c039bc0a5106..a6428823371bf1af3e2cdbc4fa552430c92d2c19 100644 (file)
@@ -1309,7 +1309,7 @@ static struct clk_regmap gxbb_32k_clk_div = {
                        &gxbb_32k_clk_sel.hw
                },
                .num_parents = 1,
-               .flags = CLK_SET_RATE_PARENT | CLK_DIVIDER_ROUND_CLOSEST,
+               .flags = CLK_SET_RATE_PARENT,
        },
 };