samr: Fix CID 1453463: Null pointer dereferences (NULL_RETURNS)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source4/rpc_server/samr/dcesrv_samr.c b/source4/rpc_server/samr/dcesrv_samr.c
index 29e1bd4608f40a0f49426aaef0a73e06502122ec..70f914bf14c728b1e69eea73ad97d7ef4525edef 100644 (file)
--- a/source4/rpc_server/samr/dcesrv_samr.c
+++ b/source4/rpc_server/samr/dcesrv_samr.c
@@ -1649,6 +1649,11 @@ static int user_iterate_callback(struct ldb_request *req,
 
                ent = &(ac->entries[ac->num_entries++]);
                val = ldb_msg_find_ldb_val(msg, "samaccountname");
+               if (val == NULL) {
+                       DBG_WARNING("samaccountname attribute not found\n");
+                       ret = ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+                       break;
+               }
                ent->name.string = talloc_steal(ac->entries,
                                                (char *)val->data);
                ent->idx = rid;