]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
nvme: add WQ_PERCPU to alloc_workqueue users
authorMarco Crivellari <marco.crivellari@suse.com>
Mon, 23 Feb 2026 10:23:28 +0000 (11:23 +0100)
committerKeith Busch <kbusch@kernel.org>
Fri, 27 Mar 2026 14:35:06 +0000 (07:35 -0700)
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

   commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
   commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

The refactoring is going to alter the default behavior of
alloc_workqueue() to be unbound by default.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU. For more details see the Link tag below.

In order to keep alloc_workqueue() behavior identical, explicitly request
WQ_PERCPU.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/
Suggested-by: Tejun Heo <tj@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/core.c
drivers/nvme/target/tcp.c

index d49f41790e4ed9db43b70512b06f58b4f7b7bf0b..03cc7d5f9683d6daac71ca0f68b26b65a0542f90 100644 (file)
@@ -1942,12 +1942,13 @@ static int __init nvmet_init(void)
        if (!nvmet_bvec_cache)
                return -ENOMEM;
 
-       zbd_wq = alloc_workqueue("nvmet-zbd-wq", WQ_MEM_RECLAIM, 0);
+       zbd_wq = alloc_workqueue("nvmet-zbd-wq", WQ_MEM_RECLAIM | WQ_PERCPU,
+                                0);
        if (!zbd_wq)
                goto out_destroy_bvec_cache;
 
        buffered_io_wq = alloc_workqueue("nvmet-buffered-io-wq",
-                       WQ_MEM_RECLAIM, 0);
+                       WQ_MEM_RECLAIM | WQ_PERCPU, 0);
        if (!buffered_io_wq)
                goto out_free_zbd_work_queue;
 
index acc71a26733f9022fb6d4ce8824859da418f2cb9..4b8b02341ddc38a1940baaf8791c994fed9e3c78 100644 (file)
@@ -2225,7 +2225,7 @@ static int __init nvmet_tcp_init(void)
        int ret;
 
        nvmet_tcp_wq = alloc_workqueue("nvmet_tcp_wq",
-                               WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
+                               WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_PERCPU, 0);
        if (!nvmet_tcp_wq)
                return -ENOMEM;