]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
Don't try to call a dialplan function's read callback from
authorMark Michelson <mmichelson@digium.com>
Thu, 16 Oct 2008 23:34:37 +0000 (23:34 +0000)
committerMark Michelson <mmichelson@digium.com>
Thu, 16 Oct 2008 23:34:37 +0000 (23:34 +0000)
the manager's GetVar handler if an invalid channel has
been specified. Several dialplan functions, including
CHANNEL and SIP_HEADER, do not check for NULL-ness of
the channel being passed in.

(closes issue #13715)
Reported by: makoto

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@150298 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/manager.c

index 8b10712e8db9f2cba856ad0ff9a874570a556df3..98f7a61f12a98b82f67df19ed2fc397be947ae9d 100644 (file)
@@ -1499,7 +1499,9 @@ static int action_getvar(struct mansession *s, const struct message *m)
 
        if (varname[strlen(varname) - 1] == ')') {
                char *copy = ast_strdupa(varname);
-
+               if (!c) {
+                       astman_send_error(s, m, "No such channel");
+               }
                ast_func_read(c, copy, workspace, sizeof(workspace));
                varval = workspace;
        } else {