]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-96143: subprocess API %s/universal_newlines=/text=/g. (GH-96468)
authorGregory P. Smith <greg@krypto.org>
Thu, 1 Sep 2022 09:47:40 +0000 (02:47 -0700)
committerGitHub <noreply@github.com>
Thu, 1 Sep 2022 09:47:40 +0000 (02:47 -0700)
minor missed test cleanup to use the modern API from the big review.

Automerge-Triggered-By: GH:gpshead
Lib/test/test_perf_profiler.py

index f587995b008f68a7820531d1e0e0614f1bef6010..2b977d78d3932484c3242b03792ea44c304235ba 100644 (file)
@@ -108,7 +108,7 @@ class TestPerfTrampoline(unittest.TestCase):
             script = make_script(script_dir, "perftest", code)
             with subprocess.Popen(
                 [sys.executable, "-Xperf", script],
-                universal_newlines=True,
+                text=True,
                 stderr=subprocess.PIPE,
                 stdout=subprocess.PIPE,
             ) as process:
@@ -157,7 +157,7 @@ class TestPerfTrampoline(unittest.TestCase):
             script = make_script(script_dir, "perftest", code)
             with subprocess.Popen(
                 [sys.executable, script],
-                universal_newlines=True,
+                text=True,
                 stderr=subprocess.PIPE,
                 stdout=subprocess.PIPE,
             ) as process:
@@ -211,7 +211,7 @@ def is_unwinding_reliable():
 def perf_command_works():
     try:
         cmd = ["perf", "--help"]
-        stdout = subprocess.check_output(cmd, universal_newlines=True)
+        stdout = subprocess.check_output(cmd, text=True)
     except (subprocess.SubprocessError, OSError):
         return False
 
@@ -237,7 +237,7 @@ def perf_command_works():
                 'print("hello")',
             )
             stdout = subprocess.check_output(
-                cmd, cwd=script_dir, universal_newlines=True, stderr=subprocess.STDOUT
+                cmd, cwd=script_dir, text=True, stderr=subprocess.STDOUT
             )
         except (subprocess.SubprocessError, OSError):
             return False