]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: xilinx: axienet: Always disable promiscuous mode
authorSean Anderson <sean.anderson@linux.dev>
Thu, 22 Aug 2024 15:40:55 +0000 (11:40 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Aug 2024 15:36:01 +0000 (17:36 +0200)
[ Upstream commit 4ae738dfef2c0323752ab81786e2d298c9939321 ]

If promiscuous mode is disabled when there are fewer than four multicast
addresses, then it will not be reflected in the hardware. Fix this by
always clearing the promiscuous mode flag even when we program multicast
addresses.

Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240822154059.1066595-2-sean.anderson@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c

index fa510f4e26008f7cf5b3c45488879e7b62a2ab80..b2e4d0b11a7d7b38646b503920ab29363023bc88 100644 (file)
@@ -450,6 +450,10 @@ static void axienet_set_multicast_list(struct net_device *ndev)
        } else if (!netdev_mc_empty(ndev)) {
                struct netdev_hw_addr *ha;
 
+               reg = axienet_ior(lp, XAE_FMI_OFFSET);
+               reg &= ~XAE_FMI_PM_MASK;
+               axienet_iow(lp, XAE_FMI_OFFSET, reg);
+
                i = 0;
                netdev_for_each_mc_addr(ha, ndev) {
                        if (i >= XAE_MULTICAST_CAM_TABLE_NUM)