]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.11] gh-104499: IDLE - fix completions for tk aqua 8.7 (GH-104591) (#104596)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Thu, 18 May 2023 02:02:53 +0000 (19:02 -0700)
committerGitHub <noreply@github.com>
Thu, 18 May 2023 02:02:53 +0000 (02:02 +0000)
gh-104499: IDLE - fix completions for tk aqua 8.7 (GH-104591)
(cherry picked from commit 678bf57ed04b8c250f0bc031ebd264bece76e731)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Lib/idlelib/NEWS.txt
Lib/idlelib/autocomplete_w.py
Misc/NEWS.d/next/IDLE/2023-05-17-17-32-21.gh-issue-104499.hNeqV4.rst [new file with mode: 0644]

index 8e8e6c33bd3e05695656134891832d57f8c7e9b5..89e86c13b25ea538866670a1fbb6308a0fb1ffe0 100644 (file)
@@ -4,6 +4,8 @@ Released after 2022-10-24
 =========================
 
 
+gh-104499: Fix completions for Tk Aqua 8.7 (currently blank).
+
 gh-104486: Make About print both tcl and tk versions if different,
 as is expected someday.
 
index 0f835a9cc1d010b29fbb4f21f1d107a90bf6b6f7..5bd7ce7f5e5adb9475c0aeae089f0187a34a2e38 100644 (file)
@@ -182,16 +182,11 @@ class AutoCompleteWindow:
         self.userwantswindow = userWantsWin
         self.lasttypedstart = self.start
 
-        # Put widgets in place
         self.autocompletewindow = acw = Toplevel(self.widget)
-        # Put it in a position so that it is not seen.
-        acw.wm_geometry("+10000+10000")
-        # Make it float
+        acw.withdraw()
         acw.wm_overrideredirect(1)
         try:
-            # This command is only needed and available on Tk >= 8.4.0 for OSX
-            # Without it, call tips intrude on the typing process by grabbing
-            # the focus.
+            # Prevent grabbing focus on maxOS.
             acw.tk.call("::tk::unsupported::MacWindowStyle", "style", acw._w,
                         "help", "noActivates")
         except TclError:
@@ -271,6 +266,7 @@ class AutoCompleteWindow:
                 # place acw above current line
                 new_y -= acw_height
             acw.wm_geometry("+%d+%d" % (new_x, new_y))
+            acw.deiconify()
             acw.update_idletasks()
         except TclError:
             pass
diff --git a/Misc/NEWS.d/next/IDLE/2023-05-17-17-32-21.gh-issue-104499.hNeqV4.rst b/Misc/NEWS.d/next/IDLE/2023-05-17-17-32-21.gh-issue-104499.hNeqV4.rst
new file mode 100644 (file)
index 0000000..20cbd9a
--- /dev/null
@@ -0,0 +1 @@
+Fix completions for Tk Aqua 8.7 (currently blank).