]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: adc: ad7606: fix serial register access
authorAngelo Dureghello <adureghello@baylibre.com>
Fri, 18 Apr 2025 18:37:53 +0000 (20:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:36:54 +0000 (14:36 +0200)
commit f083f8a21cc785ebe3a33f756a3fa3660611f8db upstream.

Fix register read/write routine as per datasheet.

When reading multiple consecutive registers, only the first one is read
properly. This is due to missing chip select deassert and assert again
between first and second 16bit transfer, as shown in the datasheet
AD7606C-16, rev 0, figure 110.

Fixes: f2a22e1e172f ("iio: adc: ad7606: Add support for software mode for ad7616")
Reviewed-by: David Lechner <dlechner@baylibre.com>
Signed-off-by: Angelo Dureghello <adureghello@baylibre.com>
Link: https://patch.msgid.link/20250418-wip-bl-ad7606-fix-reg-access-v3-1-d5eeb440c738@baylibre.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/adc/ad7606_spi.c

index e1ad2cd61b7f9bd2ca9b357d5bbffd514066a840..e9f4043966aedb90e98659574bfa22949e708394 100644 (file)
@@ -127,7 +127,7 @@ static int ad7606_spi_reg_read(struct ad7606_state *st, unsigned int addr)
                {
                        .tx_buf = &st->d16[0],
                        .len = 2,
-                       .cs_change = 0,
+                       .cs_change = 1,
                }, {
                        .rx_buf = &st->d16[1],
                        .len = 2,