]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Resolve tinydnsbackend coverity warnings
authorRuben d'Arco <cyclops@prof-x.net>
Mon, 10 Jun 2013 20:45:52 +0000 (22:45 +0200)
committerPeter van Dijk <peter.van.dijk@netherlabs.nl>
Fri, 14 Jun 2013 06:59:00 +0000 (08:59 +0200)
(8fb03db75947122da4e5425c4b517a46c54046f3+7e8f95a953ae3b5bac93e9314a7a75486618d96d)

modules/tinydnsbackend/tinydnsbackend.cc

index 36e1984f674e8a567ceace751524e0088540f29b..640f1b803b09e04ac61ba844a1b5c3a71130c724 100644 (file)
@@ -61,17 +61,20 @@ TinyDNSBackend::TinyDNSBackend(const string &suffix)
        d_locations = mustDo("locations");
        d_ignorebogus = mustDo("ignore-bogus-records");
        d_taiepoch = 4611686018427387904ULL + getArgAsNum("tai-adjust");
+       d_dnspacket = NULL;
+       d_cdbReader = NULL;
+       d_isAxfr = false;
+       d_isWildcardQuery = false;
 }
 
 void TinyDNSBackend::getUpdatedMasters(vector<DomainInfo>* retDomains) {
        Lock l(&s_domainInfoLock); //TODO: We could actually lock less if we do it per suffix.
        
-       TDI_t *domains;
        if (! s_domainInfo.count(d_suffix)) {
-               domains = new TDI_t;
-               s_domainInfo[d_suffix] = *domains;
-       } 
-       domains = &s_domainInfo[d_suffix];
+               TDI_t tmp;
+               s_domainInfo.insert( make_pair(d_suffix,tmp) );
+       }
+       TDI_t *domains = &s_domainInfo[d_suffix];
 
        vector<DomainInfo> allDomains;
        getAllDomains(&allDomains);