]> git.ipfire.org Git - thirdparty/snapper.git/commitdiff
- add ctime check only for future consideration
authorOndrej Kozina <okozina@redhat.com>
Wed, 27 Feb 2013 12:49:15 +0000 (13:49 +0100)
committerOndrej Kozina <okozina@redhat.com>
Wed, 27 Feb 2013 16:30:10 +0000 (17:30 +0100)
snapper/Compare.cc

index 8c48ead49208737a394ccfa228f454be7e547224..e82195d88ddf1faf63a4ff1b53b98fbafac98bf4 100644 (file)
@@ -183,16 +183,18 @@ namespace snapper
         unsigned int status = 0;
 
         /*
-         * NOTE:
+         * NOTE: just for a consideration
          *
          * if both ctimes are in match, files should be same
          * ctime can be altered only by some debugfs tool and
-         * on umounted fs (ext2,3,4...). So this should be safe
+         * on umounted fs (ext2,3,4, xfs). So this should be safe
          * unless root or CAP_SYS_ADMIN played with low-level fs
-         * utilities
+         * utilities, right?
+         *
+         * if ((stat1.st_ctime == stat2.st_ctime))
+         *      return status;
+         *
          */
-       if ((stat1.st_ctime == stat2.st_ctime))
-           return status;
 
        if ((stat1.st_mode & S_IFMT) != (stat2.st_mode & S_IFMT))
        {