]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net,via-rhine: Fix tx_timeout handling
authorRichard Weinberger <richard@nod.at>
Tue, 14 Jan 2014 21:46:36 +0000 (22:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Feb 2014 19:22:20 +0000 (11:22 -0800)
[ Upstream commit a926592f5e4e900f3fa903298c4619a131e60963 ]

rhine_reset_task() misses to disable the tx scheduler upon reset,
this can lead to a crash if work is still scheduled while we're resetting
the tx queue.

Fixes:
[   93.591707] BUG: unable to handle kernel NULL pointer dereference at 0000004c
[   93.595514] IP: [<c119d10d>] rhine_napipoll+0x491/0x6

Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/via/via-rhine.c

index bdf697b184ae14246a4173d09833367ba312d7df..f3ae9d94fe711b7099e7a1a656e43b18ae005e1d 100644 (file)
@@ -1615,6 +1615,7 @@ static void rhine_reset_task(struct work_struct *work)
                goto out_unlock;
 
        napi_disable(&rp->napi);
+       netif_tx_disable(dev);
        spin_lock_bh(&rp->lock);
 
        /* clear all descriptors */