Fix a segfault in base64_encode_data_blob

We did not allocate enough memory for the \0 and a = at the end

diff --git a/source/lib/util_str.c b/source/lib/util_str.c
index 1e1108132cdf37b1aca169733dda5e0b46712529..7cb57adbb59acabc906e6030ca6769b35d90d59c 100644 (file)
--- a/source/lib/util_str.c
+++ b/source/lib/util_str.c
@@ -2347,7 +2347,9 @@ char *base64_encode_data_blob(TALLOC_CTX *mem_ctx, DATA_BLOB data)
 
        out_cnt = 0;
        len = data.length;
-       output_len = data.length * 2;
+       output_len = data.length * 2 + 4; /* Account for closing bytes. 4 is
+                                          * random but should be enough for
+                                          * the = and \0 */
        result = TALLOC_ARRAY(mem_ctx, char, output_len); /* get us plenty of space */
        SMB_ASSERT(result != NULL);