]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-108562: Revert enabling -fstrict-overflow for libmpdec (GH-116302)
authorSergey B Kirpichev <skirpichev@gmail.com>
Mon, 4 Mar 2024 17:07:24 +0000 (20:07 +0300)
committerGitHub <noreply@github.com>
Mon, 4 Mar 2024 17:07:24 +0000 (18:07 +0100)
gh-108562: partial reversion of pr114751

Reverts -fstrict-overflow for libmpdec

Makefile.pre.in
configure
configure.ac

index 396a3d4dca30e4da73f5e0a1bbc478af1ce8c73d..ee65ecd918ce2adcff05834015cc8d3baf0c97d7 100644 (file)
@@ -1213,7 +1213,7 @@ PYTHON_HEADERS= \
 
 ##########################################################################
 # Build static libmpdec.a
-LIBMPDEC_CFLAGS=$(PY_STDMODULE_CFLAGS) @LIBMPDEC_CFLAGS@ $(CCSHARED)
+LIBMPDEC_CFLAGS=@LIBMPDEC_CFLAGS@ $(PY_STDMODULE_CFLAGS) $(CCSHARED)
 
 # "%.o: %c" is not portable
 Modules/_decimal/libmpdec/basearith.o: $(srcdir)/Modules/_decimal/libmpdec/basearith.c $(LIBMPDEC_HEADERS) $(PYTHON_HEADERS)
index c0614138ead4b7a5ea89c1ef9501ca79f8dcf563..4a980fea4536979fce52629ef3969d72abe8ebb0 100755 (executable)
--- a/configure
+++ b/configure
@@ -14516,13 +14516,6 @@ else $as_nop
   LIBMPDEC_LDFLAGS="-lm \$(LIBMPDEC_A)"
   LIBMPDEC_INTERNAL="\$(LIBMPDEC_HEADERS) \$(LIBMPDEC_A)"
 
-    if test "x$ac_cv_cc_supports_fstrict_overflow" = xyes
-then :
-
-    as_fn_append LIBMPDEC_CFLAGS " -fstrict-overflow"
-
-fi
-
     if test "x$with_pydebug" = xyes
 then :
 
index e40b8e0d0de9fc98ff0ef476054bc79f03d5df7b..103c24962b7b420efa54173a89934ed7ff200153 100644 (file)
@@ -3896,11 +3896,6 @@ AS_VAR_IF([with_system_libmpdec], [yes], [
   LIBMPDEC_LDFLAGS="-lm \$(LIBMPDEC_A)"
   LIBMPDEC_INTERNAL="\$(LIBMPDEC_HEADERS) \$(LIBMPDEC_A)"
 
-  dnl Enable strict-overflow for libmpdec, if available, see GH-108562
-  AS_VAR_IF([ac_cv_cc_supports_fstrict_overflow], [yes], [
-    AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -fstrict-overflow"])
-  ])
-
   dnl Disable forced inlining in debug builds, see GH-94847
   AS_VAR_IF([with_pydebug], [yes], [
     AS_VAR_APPEND([LIBMPDEC_CFLAGS], [" -DTEST_COVERAGE"])