]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/xe: Fix a NULL vs IS_ERR() in xe_vm_add_compute_exec_queue()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 7 Aug 2025 15:53:41 +0000 (18:53 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Sep 2025 09:13:48 +0000 (11:13 +0200)
[ Upstream commit cbc7f3b4f6ca19320e2eacf8fc1403d6f331ce14 ]

The xe_preempt_fence_create() function returns error pointers.  It
never returns NULL.  Update the error checking to match.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/aJTMBdX97cof_009@stanley.mountain
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit 75cc23ffe5b422bc3cbd5cf0956b8b86e4b0e162)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/xe/xe_vm.c

index a4845d4213b0061a3ea61ee45f3a58a10d79591d..fc5f0e1351932a5e455e159eddfbf940d245ad61 100644 (file)
@@ -239,8 +239,8 @@ int xe_vm_add_compute_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q)
 
        pfence = xe_preempt_fence_create(q, q->lr.context,
                                         ++q->lr.seqno);
-       if (!pfence) {
-               err = -ENOMEM;
+       if (IS_ERR(pfence)) {
+               err = PTR_ERR(pfence);
                goto out_fini;
        }