]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amd/display: Skip finding free audio for unknown engine_id
authorAlex Hung <alex.hung@amd.com>
Mon, 22 Apr 2024 19:52:27 +0000 (13:52 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Jul 2024 09:40:48 +0000 (11:40 +0200)
[ Upstream commit 1357b2165d9ad94faa4c4a20d5e2ce29c2ff29c3 ]

[WHY]
ENGINE_ID_UNKNOWN = -1 and can not be used as an array index. Plus, it
also means it is uninitialized and does not need free audio.

[HOW]
Skip and return NULL.

This fixes 2 OVERRUN issues reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Acked-by: Wayne Lin <wayne.lin@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/display/dc/core/dc_resource.c

index cdcd5051dd66617253e2d01e88370fe345e048ce..2f56684780eb519a64a5e5828ee579392c17f3b8 100644 (file)
@@ -1646,6 +1646,9 @@ static struct audio *find_first_free_audio(
 {
        int i, available_audio_count;
 
+       if (id == ENGINE_ID_UNKNOWN)
+               return NULL;
+
        available_audio_count = pool->audio_count;
 
        for (i = 0; i < available_audio_count; i++) {