- Fixed a ./configure bug where compile tests were failing due to

  "-Werror" (unused variable) rather than the actual test failure.  Lead
  to inconsistent and unworkable auto-configurations.  [ISC-Bugs #17177]

diff --git a/RELNOTES b/RELNOTES
index 41c2e2cc36b10233c45d603ed36f4564f4fc8fd4..9032210419772a585e1cc20a6db814633135e0d2 100644 (file)
--- a/RELNOTES
+++ b/RELNOTES
@@ -68,6 +68,10 @@ suggested fixes to <dhcp-users@isc.org>.
 - Fixed an error causing the server to lock up on lease expiration,
   reported independently by Jothilingam Vasu and Dennis Kou.
 
+- Fixed a ./configure bug where compile tests were failing due to
+  "-Werror" (unused variable) rather than the actual test failure.  Lead
+  to inconsistent and unworkable auto-configurations.
+
                        Changes since 4.0.0a2
 
 - Fix for startup where there are no IPv4 addresses on an interface.

diff --git a/configure.ac b/configure.ac
index 9ca0a42927fff738d8a69bf0f57f1befad881627..4549c00c24aeb716dcb0f97a79da4f31d30be384 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -16,7 +16,7 @@ AC_PROG_CC
 # user did not specify any flags. Add warnings in this case.
 if test "$GCC" = "yes"; then
        if test "$CFLAGS" != "$SAVE_CFLAGS"; then
-               CFLAGS="$CFLAGS -Wall -Werror -fno-strict-aliasing"
+               STD_CWARNINGS="$STD_CWARNINGS -Wall -Werror -fno-strict-aliasing"
        fi
 fi
 
@@ -208,6 +208,10 @@ AC_CHECK_MEMBER(struct msghdr.msg_control,,
 #include <sys/socket.h>
        ])
 
+# Append selected warning levels to CFLAGS before substitution (but after
+# AC_TRY_COMPILE & etc).
+CFLAGS="$CFLAGS $STD_CWARNINGS"
+
 AC_OUTPUT([
   Makefile
   client/Makefile