]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: SDCA: bug fix while parsing mipi-sdca-control-cn-list
authorNiranjan H Y <niranjan.hy@ti.com>
Mon, 10 Nov 2025 15:26:46 +0000 (20:56 +0530)
committerMark Brown <broonie@kernel.org>
Mon, 10 Nov 2025 16:22:49 +0000 (16:22 +0000)
"struct sdca_control" declares "values" field as integer array.
But the memory allocated to it is of char array. This causes
crash for sdca_parse_function API. This patch addresses the
issue by allocating correct data size.

Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20251110152646.192-1-niranjan.hy@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdca/sdca_functions.c

index 13f68f7b6dd6aff6ba1b07be8e48faa3a9209f05..0ccb6775f4de3dab1ee3447d371128a96490462f 100644 (file)
@@ -894,7 +894,8 @@ static int find_sdca_entity_control(struct device *dev, struct sdca_entity *enti
                return ret;
        }
 
-       control->values = devm_kzalloc(dev, hweight64(control->cn_list), GFP_KERNEL);
+       control->values = devm_kcalloc(dev, hweight64(control->cn_list),
+                                      sizeof(int), GFP_KERNEL);
        if (!control->values)
                return -ENOMEM;