fbdev: valkyriefb: Fix reference count leak in valkyriefb_init

The of_find_node_by_name() function returns a device tree node with its
reference count incremented. The caller is responsible for calling
of_node_put() to release this reference when done.

Found via static analysis.

Fixes: cc5d0189b9ba ("[PATCH] powerpc: Remove device_node addrs/n_addr")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/valkyriefb.c b/drivers/video/fbdev/valkyriefb.c
index 91d070ef69897d0002ce9f1fb368c9fe9e23ecba..6ff059ee169418a6f0c839ac9a1ee3bf315b35cb 100644 (file)
--- a/drivers/video/fbdev/valkyriefb.c
+++ b/drivers/video/fbdev/valkyriefb.c
@@ -329,11 +329,13 @@ static int __init valkyriefb_init(void)
 
                if (of_address_to_resource(dp, 0, &r)) {
                        printk(KERN_ERR "can't find address for valkyrie\n");
+                       of_node_put(dp);
                        return 0;
                }
 
                frame_buffer_phys = r.start;
                cmap_regs_phys = r.start + 0x304000;
+               of_node_put(dp);
        }
 #endif /* ppc (!CONFIG_MAC) */